-
Notifications
You must be signed in to change notification settings - Fork 0
Conversation
…volution-node into feat/relayer-updates
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I approve, although I'm not 100% sure about whether the commenting out of TryRuntime will have any impact. I leave that to the developer and the 2nd reviewer.
// )) | ||
// }) | ||
// TODO: uncomment and fix it | ||
Ok(()) |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
it will be nicer to add a todo!()
instead of do nothing and exit silently
I think the todo!() request is kind of mandatory
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I think we should make the user know that the command is not implemented
closed in favour of #50 |
messages
,relayers
,bridge-grandpa
, etc.)beefy
gadget to the client