This repository has been archived by the owner on Oct 11, 2023. It is now read-only.
Add bridge components #47
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…volution-node into feat/relayer-updates
ghost
marked this pull request as ready for review
tonimateos
approved these changes
Aug 7, 2023
asiniscalchi
previously approved these changes
Aug 7, 2023
| // )) | ||
| // }) | ||
| // TODO: uncomment and fix it | ||
| Ok(()) |
There was a problem hiding this comment.
it will be nicer to add a todo!() instead of do nothing and exit silently
asiniscalchi
dismissed
their stale review
I think the todo!() request is kind of mandatory
asiniscalchi
suggested changes
Aug 7, 2023
|
closed in favour of #50 |
ghost
closed this
This pull request was closed.
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
messages,relayers,bridge-grandpa, etc.)beefygadget to the client